-
Notifications
You must be signed in to change notification settings - Fork 1k
compiler: include the scope in the type code name #5183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
cec236b to
4fd15a3
Compare
|
Maybe add this to the compiler frontend tests ( |
4fd15a3 to
91c1d8a
Compare
|
I don't think I can put it in the golden |
|
Oh, we should not be using the pointer address for this. |
|
There doesn't appear to be anything else aside from pointer addresses to allow us to differentiate scopes. Even the |
|
Note also this the pointer address of the scope in the compiler, not the pointer at runtime on the device. |
|
If that is the case then we could loop through the SSA and assign numbers to them? Non-deterministic compilation is not acceptable. |
|
Ok. I'll see what I can come up with. |
|
PTAL |
Fixes #5180